Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check python/uv/ folder with mypy #7891

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Check python/uv/ folder with mypy #7891

merged 2 commits into from
Oct 3, 2024

Conversation

sobolevn
Copy link
Contributor

@sobolevn sobolevn commented Oct 3, 2024

It used to report:

» mypy 
python/uv/_build_backend.py:40: error: Incompatible types in assignment (expression has type "list[str]", variable has type "CompletedProcess[bytes]")  [assignment]
python/uv/_build_backend.py:41: error: Value of type "CompletedProcess[bytes]" is not indexable  [index]
python/uv/_build_backend.py:46: error: Value of type "CompletedProcess[bytes]" is not indexable  [index]
Found 3 errors in 1 file (checked 6 source files)

So, I had to fix this problem by renaming the result var.

@charliermarsh charliermarsh merged commit d5c5a29 into astral-sh:main Oct 3, 2024
79 checks passed
@charliermarsh
Copy link
Member

Thanks!

@charliermarsh charliermarsh added the internal A refactor or improvement that is not user-facing label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @charliermarsh @AlexWaygood